[Fix] Clear cached validator requests on disconnect #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaslong
changed the title
node/bft/src/helpers/cache.rs
Outdated
Comment on lines
43
to
45
| /// Note: we don't clear this map based on time but only on peer disconnect. | ||
| /// This is sufficient to avoid infinite growth as the committee has a fixed number | ||
| /// of members. |
There was a problem hiding this comment.
Suggested change
| /// Note: we don't clear this map based on time but only on peer disconnect. | |
| /// This is sufficient to avoid infinite growth as the committee has a fixed number | |
| /// of members. | |
| /// The map of IPs to the number of validators requests |
This shouldn't be explained within the struct member comment, but instead on the invocation of clear_outbound_validators_requests
raychu86
reviewed
May 16, 2024
raychu86
approved these changes
May 16, 2024
howardwu
approved these changes
May 23, 2024
vicsn
added a commit
to AleoHQ/snarkOS
that referenced
this pull request
May 28, 2024
…ache"" This reverts commit 0829e52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clears the validator requests cache map for a particular peer on disconnect. This ensures the collection is periodically cleaned up despite not having a time-based expiry and is sufficient to avoid infinite growth as the committee size is bounded (but the IP may change).
A small aside for future discussion: when time permits, we may want to revisit our approach to cache invalidation both in the gateway and the router. One option would be to use an LRU with a fixed size that we clear on specific state transitions (e.g. on round increment).