Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #114

Open
wants to merge 55 commits into
base: develop
Choose a base branch
from
Open

Update readme #114

wants to merge 55 commits into from

Conversation

AlexPerathoner
Copy link
Owner

No description provided.

@AlexPerathoner
Copy link
Owner Author

AlexPerathoner commented Feb 7, 2023

image

nice xd @kaydenanderson

@AlexPerathoner
Copy link
Owner Author

A couple of things:

  1. Please include the three screens of the settings window (https://github.com/AlexPerathoner/SlimHUD/tree/feature/settings-design). They look great, not including would be a shame
  2. You should use the format using the image in the Screens folder, not the url (e.g. https://user-images.githubusercontent.com/104660117/215941948-2b297736-2925-4964-8b26-795fdba21d56). You can merge feature/settings-design into repo/update-readme to get those screens in your branch, too
  3. Some tables are malformed, you can check them out here: https://github.com/AlexPerathoner/SlimHUD/tree/repo/update-readme
  4. I'm not sure about the font you used in the custom graphics:

image

Why not use SF Pro / Display (which is used in the app, too?

@kaydenanderson
Copy link
Collaborator

hey there @AlexPerathoner!
sure thing! :)
as for #4, that is actually SF Pro Display/medium, so i adjusted it to Semibold to make it more obvious - hope that works.

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kaydenanderson kaydenanderson marked this pull request as ready for review February 8, 2023 01:58
@AlexPerathoner
Copy link
Owner Author

Actually the correct font to use should be the default used by GitHub for markdown styling @kaydenanderson that's why SF was standing out

@AlexPerathoner AlexPerathoner mentioned this pull request Feb 8, 2023
@AlexPerathoner
Copy link
Owner Author

@kaydenanderson do you need help? xd
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants