Support config params for XT5 and light fixes #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Network indicator [LED] - Vibration [XToggleNum] - On/Off/Preview sound and light effects [XT5Select] - On/Off state indicator (color and position) [XT5LightStatusLight]
…5Light'>) does not set supported color modes, this will stop working in Home Assistant Core 2025.3]
|
The code design is very different from what is in the repository. It needs to be rewritten. I'll take a look at it when I get a time. |
|
Hi, I tried to make the new entities as much reusable as possible, but sure, it can be modified to fit better with the repository. If you give me some clues, I can try to work on it |
|
Specs description are very different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Support configs for XT5
Also, two fixes: