Add PropertyKey for file not found metadata cache #18491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbw9580
requested changes
Feb 1, 2024
| @@ -73,6 +73,7 @@ public void before() throws Exception { | |||
| mConf.set(PropertyKey.USER_METADATA_CACHE_MAX_SIZE, 1000, Source.RUNTIME); | |||
| // Avoid async update file access time to call getStatus to mess up the test results | |||
| mConf.set(PropertyKey.USER_UPDATE_FILE_ACCESSTIME_DISABLED, true); | |||
| mConf.set(PropertyKey.USER_METADATA_CACHE_NOT_FOUND_CACHE_ENABLED, true); | |||
There was a problem hiding this comment.
Since the default value for USER_METADATA_CACHE_NOT_FOUND_CACHE_ENABLED is false, add a unit test to test that when it's not enabled, a missing file won't be cached.
Co-authored-by: Bowen Ding <6999708+dbw9580@users.noreply.github.com>
Co-authored-by: Bowen Ding <6999708+dbw9580@users.noreply.github.com>
Co-authored-by: Bowen Ding <6999708+dbw9580@users.noreply.github.com>
…ForFNFMetadataCache
…ForFNFMetadataCache
…long/alluxio into addPropertyKeyForFNFMetadataCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add PropertyKey for file not found metadata cache
Why are the changes needed?
Without this PR, dora fuse cannot copy a file to dora cluster through dora fuse
Does this PR introduce any user facing changes?
Add a new PropertyKey
alluxio.user.metadata.cache.not.found.cache.enabled