-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Able to override settings for workspace through .androidide/settings.json inside project #1788
base: dev
Are you sure you want to change the base?
Conversation
…tings.json inside project
I haven't added to customize the action for the app, for example override the task in quick run menu: {
"action.quickRun": "bash gradlew run"
} Because you said that it could be a huge security vulnerability. But I'll add it also if you say. |
And I have only added a few editor settings because I don't think all the settings are necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the issues mentioned, there are unnecessary changes in the files as well (mostly formatting).
completionsMatchLower = workspaceSettings.completionsMatchLower | ||
drawLeadingWs = workspaceSettings.drawLeadingWs | ||
drawTrailingWs = workspaceSettings.drawTrailingWs | ||
drawInnerWs = workspaceSettings.drawInnerWs | ||
drawEmptyLineWs = workspaceSettings.drawEmptyLineWs | ||
drawLineBreak = workspaceSettings.drawLineBreak | ||
fontSize = workspaceSettings.fontSize | ||
tabSize = workspaceSettings.tabSize | ||
autoSave = workspaceSettings.autoSave | ||
fontLigatures = workspaceSettings.fontLigatures | ||
visiblePasswordFlag = workspaceSettings.visiblePasswordFlag | ||
wordwrap = workspaceSettings.wordwrap | ||
useSoftTab = workspaceSettings.useSoftTab | ||
deleteTabsOnBackspace = workspaceSettings.deleteTabsOnBackspace | ||
stickyScrollEnabled = workspaceSettings.stickyScrollEnabled | ||
pinLineNumbers = workspaceSettings.pinLineNumbers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach is incorrect. You're updating the global IDE preferences here, which will affect other projects as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other project will be affected only once and next time that project also has its own settings.json file then it will be applied while opening the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must not affect anything other than the preferences for that specific project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
fixes (#1674)