Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use -mkfs-time #1150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not use -mkfs-time #1150

wants to merge 2 commits into from

Conversation

probonopd
Copy link
Member

TheAssassin
TheAssassin requested changes Sep 23, 2021
View reviewed changes
Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the builds.

src/appimagetool.c Outdated Show resolved Hide resolved
src/appimagetool.c Outdated Show resolved Hide resolved
@probonopd
Copy link
Member Author

Please fix the builds.

Great question why they are broken...

@probonopd
Copy link
Member Author

On aarch64 the error is

Hash ace9c8034b826d84c72d038b7be50e173417ae4ecc79aa773649957d9ab6244d doesn't match hash e12425edcb5ef578f23efce4dd9d95ff459e7bdc9eeea94539173d77fb85fcb7!

This seems unrelated to this PR to me. Does anyone know what might be going on there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAssassin TheAssassin TheAssassin requested changes

@azubieta azubieta Awaiting requested review from azubieta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@probonopd @TheAssassin