README: Adding ExternalProject_Add example #652
Conversation
|
@TheAssassin as our CMake artist in residence, does this "speak" to you? |
|
Looks quite a bit cryptic to me, too. I'll have a detailed look next week. |
|
Oops, I thought you merged the PR already. I forgot you have permissions to push into my branches if they are used for PRs 😅 |
|
So, I suppose this is about building appimagetool and using it in your project, rather than using our (relatively new) libappimage? I'll clarify that a bit then in the README. |
|
Ok, feel free to do that. No, I'm not using the libappimage, but I guess it should be easy to prevent CMake to generate Makefiles, which build only libappimage 😉 |
|
I'm confused on what the PR actually does? |
| CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_PREFIX_PATH=${CMAKE_INSTALL_PREFIX} -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=ON | ||
| ) | ||
|
|
||
| SetProjectDependencies(TARGET AppImageKit DEPENDS glib libfuse cairo OpenSSL patch sed wget) |
There was a problem hiding this comment.
This doesn't seems to be a native CMake function. I suppose it's a custom macro.
In order to allow other user to reuse your code snippet you must only use native functions.
|
Yes, SetProjectDependencies is custom and the BUILD_OS_LINUX variable as
well.
|
|
This PR has been closed by the original author. No need for reviews or anything. |
|
Unexpected side effect of renaming of master branch. Sorry for the noise. Changing base and reopening. |
Added a short description how I added AppImageKit in one of my projects.