Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added categorized slices for piechart (labels per slice) #165

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ar-rahimi
Copy link

I have added label to the piechart view because the piechart is kinda not informative enough without categorizing the slices

Description

When hovering over a slice it will show the category the slice belongs to left from the the slice percentage.

Motivation and Context

The piechart is more informative now.

How Has This Been Tested?

I have tested this in my application before request a pr

Screenshots (if appropriate):

labledpiechart

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (Updating Documentation, CI automation, etc..)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@patpatpat123
Copy link

Hello,

May I ask if this PR will also help #13 please?

Thank you

@ar-rahimi
Copy link
Author

Hello,

May I ask if this PR will also help #13 please?

Thank you

yes it will help please check this fork: https://github.com/ar-rahimi/ChartView/commits/master

@patpatpat123
Copy link

Hello,
May I ask if this PR will also help #13 please?
Thank you

yes it will help please check this fork: https://github.com/ar-rahimi/ChartView/commits/master

Got it. Hope this can be merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants