Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positions of Line View #184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

yeahsilver
Copy link

when I used the Line View, the position is quite different from the actual value, so I've made up the decision to fix this part

Description

Your own project be like

스크린샷 2021-01-18 오후 3 28 04

스크린샷 2021-01-18 오후 3 29 53

As you seen. the graph above has the gap btw the actual value and the guide line of this chart view ( I don't know whether you intended to or not)

I had a little trouble of using it, so I'd suggest you to see what I did in my repo.

What I fixed is like,

스크린샷 2021-01-18 오후 3 33 25

But when I had fixed only this part, the chart had not worked well

스크린샷 2021-01-18 오후 3 37 16

Hence, I fixed a bit of MagnifierRectangle like this
스크린샷 2021-01-18 오후 3 46 28

That's all what I fixed!

Consider you guys to fix it.
if not, I just wish that I would help others who would have trouble of doing it.

Motivation and Context

As I wrote above, the actual value and the visual graph is little different. I want to match up the actual value and the guide line of the chart, so I request you!

How Has This Been Tested?

About 1 week

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (Updating Documentation, CI automation, etc..)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant