Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format logging output in a form of a table #569

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Andrei-Aksionov
Copy link

@Andrei-Aksionov Andrei-Aksionov commented Feb 28, 2024

Hello there 👋

Thanks for repo!
Decided to add my little contribution.

With the current main the logging output during quantization is such:

INFO - Start quantizing layer 1/6
INFO - Quantizing attn.attn in layer 1/6...
INFO - Quantizing attn.proj in layer 1/6...
INFO - Quantizing mlp.fc in layer 1/6...
INFO - Quantizing mlp.proj in layer 1/6...
INFO - Start quantizing layer 2/6
INFO - Quantizing attn.attn in layer 2/6...
INFO - Quantizing attn.proj in layer 2/6...
INFO - Quantizing mlp.fc in layer 2/6...
INFO - Quantizing mlp.proj in layer 2/6...
INFO - Start quantizing layer 3/6
INFO - Quantizing attn.attn in layer 3/6...
INFO - Quantizing attn.proj in layer 3/6...
INFO - Quantizing mlp.fc in layer 3/6...
INFO - Quantizing mlp.proj in layer 3/6...
INFO - Start quantizing layer 4/6
INFO - Quantizing attn.attn in layer 4/6...
INFO - Quantizing attn.proj in layer 4/6...
INFO - Quantizing mlp.fc in layer 4/6...
INFO - Quantizing mlp.proj in layer 4/6...
INFO - Start quantizing layer 5/6
INFO - Quantizing attn.attn in layer 5/6...
INFO - Quantizing attn.proj in layer 5/6...
INFO - Quantizing mlp.fc in layer 5/6...
INFO - Quantizing mlp.proj in layer 5/6...
INFO - Start quantizing layer 6/6
INFO - Quantizing attn.attn in layer 6/6...
INFO - Quantizing attn.proj in layer 6/6...
INFO - Quantizing mlp.fc in layer 6/6...
INFO - Quantizing mlp.proj in layer 6/6...

and with the PR:

2024-02-28 | 11:33:03 | INFO | auto_gptq.modeling._base    | --- Start quantizing layer 1/6 ---
2024-02-28 | 11:33:03 | INFO | auto_gptq.modeling._base    | Quantizing attn.attn in layer 1/6...
2024-02-28 | 11:33:04 | INFO | auto_gptq.modeling._base    | Quantizing attn.proj in layer 1/6...
2024-02-28 | 11:33:04 | INFO | auto_gptq.modeling._base    | Quantizing mlp.fc in layer 1/6...
2024-02-28 | 11:33:04 | INFO | auto_gptq.modeling._base    | Quantizing mlp.proj in layer 1/6...
2024-02-28 | 11:33:04 | INFO | auto_gptq.modeling._base    | --- Start quantizing layer 2/6 ---
2024-02-28 | 11:33:04 | INFO | auto_gptq.modeling._base    | Quantizing attn.attn in layer 2/6...
2024-02-28 | 11:33:04 | INFO | auto_gptq.modeling._base    | Quantizing attn.proj in layer 2/6...
2024-02-28 | 11:33:04 | INFO | auto_gptq.modeling._base    | Quantizing mlp.fc in layer 2/6...
2024-02-28 | 11:33:04 | INFO | auto_gptq.modeling._base    | Quantizing mlp.proj in layer 2/6...
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | --- Start quantizing layer 3/6 ---
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | Quantizing attn.attn in layer 3/6...
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | Quantizing attn.proj in layer 3/6...
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | Quantizing mlp.fc in layer 3/6...
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | Quantizing mlp.proj in layer 3/6...
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | --- Start quantizing layer 4/6 ---
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | Quantizing attn.attn in layer 4/6...
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | Quantizing attn.proj in layer 4/6...
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | Quantizing mlp.fc in layer 4/6...
2024-02-28 | 11:33:05 | INFO | auto_gptq.modeling._base    | Quantizing mlp.proj in layer 4/6...
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | --- Start quantizing layer 5/6 ---
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | Quantizing attn.attn in layer 5/6...
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | Quantizing attn.proj in layer 5/6...
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | Quantizing mlp.fc in layer 5/6...
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | Quantizing mlp.proj in layer 5/6...
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | --- Start quantizing layer 6/6 ---
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | Quantizing attn.attn in layer 6/6...
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | Quantizing attn.proj in layer 6/6...
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | Quantizing mlp.fc in layer 6/6...
2024-02-28 | 11:33:06 | INFO | auto_gptq.modeling._base    | Quantizing mlp.proj in layer 6/6...

Of course it's a matter of personal preference, but I think that the table looks more tidy.
Plus I visually separated each layer with --- signs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant