Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect global packages folder in BuildToNuGetCache #15706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented May 13, 2024

What does the pull request do?

This PR ensures that the configured NuGet global packages folder is respected in the BuildToNuGetCache build target, whether it's set via NuGet.config or the NUGET_PACKAGES environment variable.

What is the current behavior?

The path is hardcoded to the default ~/.nuget/packages folder.

@MrJul MrJul added the area-infrastructure Issues related to CI/tooling infrastructur label May 13, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048385-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@kekekeks
Copy link
Member

I'm really reluctant to use any Nuke features at this point. They tend to break in spectacular ways with SDK updates

@MrJul
Copy link
Member Author

MrJul commented May 13, 2024

It comes from the standard NuGet.Configuration NuGet package though, so hopefully that shouldn't break, as there's no Nuke wrapper involved here.

That being said, I went with the official API as it was the most convenient and compatible with NuGet.config overrides, but I'm only interested in the NUGET_PACKAGES environment variable if you prefer a hackish-way that doesn't use NuGet.Configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Issues related to CI/tooling infrastructur
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants