Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Semantic Kernel functions to not rely on LangChain #759

Closed
3 tasks
Tracked by #320
cecheta opened this issue Apr 25, 2024 · 3 comments · Fixed by #877
Closed
3 tasks
Tracked by #320

Update Semantic Kernel functions to not rely on LangChain #759

cecheta opened this issue Apr 25, 2024 · 3 comments · Fixed by #877
Assignees
@gaurarpit
Labels
subtask A subtask

Comments

@cecheta
Copy link
Collaborator

cecheta commented Apr 25, 2024 •
edited

Required by #320

Description

Replace the existing functions, which use LangChain, to use Semantic Kernel functions that do not rely on LangChain.

Tasks

_To be filled in by the engineer picking up the subtask

  • Update QuestionAnswerTool
  • Update TextProcessingTool
  • Update PostPromptTool
@cecheta cecheta mentioned this issue Apr 25, 2024
Closed
5 tasks
@cecheta cecheta added the subtask A subtask label Apr 25, 2024
@gaurarpit
Copy link
Collaborator

gaurarpit commented May 13, 2024 •
edited

anyone wants to pair with me on this one?

@gaurarpit gaurarpit self-assigned this May 13, 2024
@gaurarpit
Copy link
Collaborator

thank you @superhindupur for pairing.

@gaurarpit
Copy link
Collaborator

discussed with @cecheta and @superhindupur and agreed on below:

  • Langchain is being used in QuestionAnswerTool, TextProcessingTool, PostPromptTool as a library rather than a orchestration provider.
  • therefore there is no need to update these files
  • Semantic Kernel orchestration processes the entire request flow using its own kernel's functions already.
  • verified by doing a debug call on the entire chat flow.

@gaurarpit gaurarpit mentioned this issue May 13, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaurarpit gaurarpit

Labels
subtask A subtask
Projects
None yet
Milestone
No milestone
2 participants
@gaurarpit @cecheta