Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use semantic kernel instead of langchain #877

Merged
merged 5 commits into from May 13, 2024
Merged

refactor: use semantic kernel instead of langchain #877

merged 5 commits into from May 13, 2024

Conversation

gaurarpit
Copy link
Collaborator

@gaurarpit gaurarpit commented May 13, 2024 •
edited

Purpose

discussed with @cecheta and @superhindupur and agreed on below:

Langchain is being used in QuestionAnswerTool, TextProcessingTool, PostPromptTool as a library rather than a orchestration provider.
therefore there is no need to update these files
Semantic Kernel orchestration processes the entire request flow using its own kernel's functions already.
verified by doing a debug call on the entire chat flow.

Ref: #759 (comment)

Does this introduce a breaking change?

  • Yes
  • No

@gaurarpit gaurarpit self-assigned this May 13, 2024
@gaurarpit gaurarpit changed the title feature: use semantic kernel instead of langchain refactor: use semantic kernel instead of langchain May 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/plugins
   ChatPlugin.py150100% 
   PostAnsweringPlugin.py80100% 
TOTAL229667570% 

Tests Skipped Failures Errors Time
178 0 💤 0 ❌ 0 🔥 10.915s ⏱️

@gaurarpit gaurarpit marked this pull request as ready for review May 13, 2024 09:54
@gaurarpit gaurarpit added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 76d1557 May 13, 2024
12 checks passed
@gaurarpit gaurarpit deleted the arpit/feature/semantic-kernel-instead-of-langchain branch May 13, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecheta cecheta cecheta approved these changes

@superhindupur superhindupur Awaiting requested review from superhindupur

Assignees

@gaurarpit gaurarpit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Semantic Kernel functions to not rely on LangChain
2 participants
@gaurarpit @cecheta