Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [IV] Reprocess All documents functionality #870

Merged
merged 45 commits into from May 14, 2024
Merged

feat: [IV] Reprocess All documents functionality #870

merged 45 commits into from May 14, 2024

Conversation

komalg1
Copy link
Collaborator

@komalg1 komalg1 commented May 10, 2024

Purpose

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
  • When AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION is true and documents were ingested to the storage, 'Reprocess All' button click will reset, re-run the indexer and index the documents again.

What to Check

Verify that the following are valid

  • Indexed documents will be visible in 'Explore Data' page

komalg1 and others added 30 commits April 29, 2024 08:35
@komalg1
module load issue
c3e4026
@komalg1
Merge branch 'main' of https://github.com/komalg1/chat-with-your-data…
2f68227 
…-solution-accelerator
@komalg1
sync main
c363956
@komalg1
Merge branch 'main' of https://github.com/komalg1/chat-with-your-data…
5962563 
…-solution-accelerator
@komalg1
Merge branch 'Azure-Samples:main' into main
090fea3
@komalg1
Merge branch 'Azure-Samples:main' into main
e34ba0a
@komalg1
Merge branch 'Azure-Samples:main' into main
38e17f1
@komalg1
Merge branch 'Azure-Samples:main' into main
ca5603e
@komalg1
Merge branch 'main' of https://github.com/komalg1/chat-with-your-data…
25dfd7d 
…-solution-accelerator
@komalg1
Merge branch 'Azure-Samples:main' into main
b4e0ed7
@komalg1
Merge branch 'Azure-Samples:main' into main
bf572b5
@komalg1
Merge branch 'Azure-Samples:main' into main
c4b451f
@komalg1
Merge branch 'Azure-Samples:main' into main
dabf403
@komalg1
Bug fix: display message when index not created for explore & delete …
09d58c1 
…page
@komalg1
increasing code coverage
39f49cc
@komalg1
Merge branch 'Azure-Samples:main' into main
79e4841
@komalg1
Merge branch 'main' into komal/iv-noindexbug
9412fd3
@komalg1
Reprocess all changes
5b4472d
@komalg1
code review
07bb93c
@komalg1
Merge branch 'Azure-Samples:main' into main
6d85cae
@komalg1
Merge branch 'main' into komal/iv-noindexbug
6433c1d
@komalg1
Merge branch 'Azure-Samples:main' into main
b44ff38
@komalg1
Merge branch 'main' into komal/iv-noindexbug
6cafc73
@komalg1
reprocess all tests
dc19453
@komalg1
type declaration
6d78142
@komalg1
Merge branch 'komal/iv-noindexbug' into komal/iv-reprocessall
b11c8d8
@komalg1
Merge branch 'Azure-Samples:main' into main
022be98
@komalg1
Merge branch 'Azure-Samples:main' into main
8964b07
@komalg1
Merge branch 'Azure-Samples:main' into main
f956b6b
@komalg1
Merge branch 'main' into komal/iv-reprocessall
7500cd8
adamdougal
adamdougal reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Just needs a few more tests

code/backend/batch/BatchStartProcessing.py Outdated Show resolved Hide resolved
code/backend/batch/utilities/helpers/embedders/integrated_vectorization_embedder.py Show resolved Hide resolved
code/tests/utilities/integrated_vectorization/test_azure_search_indexer.py Show resolved Hide resolved
@komalg1 komalg1 requested a review from adamdougal May 14, 2024 11:49
adamdougal
adamdougal approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@komalg1 komalg1 added this pull request to the merge queue May 14, 2024
Merged via the queue into Azure-Samples:main with commit 89e328b May 14, 2024
6 checks passed
@komalg1 komalg1 deleted the komal/iv-reprocessall branch May 14, 2024 12:23
@frtibble frtibble mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdougal adamdougal adamdougal approved these changes

@gaurarpit gaurarpit gaurarpit left review comments

@cecheta cecheta Awaiting requested review from cecheta

@superhindupur superhindupur Awaiting requested review from superhindupur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update 'Reprocess All documents" button to run the indexer when using Pull approach
5 participants
@komalg1 @adamdougal @superhindupur @gaurarpit @cecheta