Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete from storage #876

Closed
wants to merge 18 commits into from
Closed

delete from storage #876

wants to merge 18 commits into from

Conversation

komalg1
Copy link
Collaborator

@komalg1 komalg1 commented May 13, 2024

Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

komalg1 and others added 18 commits April 29, 2024 08:35
@komalg1
module load issue
c3e4026
@komalg1
Merge branch 'main' of https://github.com/komalg1/chat-with-your-data…
2f68227 
…-solution-accelerator
@komalg1
sync main
c363956
@komalg1
Merge branch 'main' of https://github.com/komalg1/chat-with-your-data…
5962563 
…-solution-accelerator
@komalg1
Merge branch 'Azure-Samples:main' into main
090fea3
@komalg1
Merge branch 'Azure-Samples:main' into main
e34ba0a
@komalg1
Merge branch 'Azure-Samples:main' into main
38e17f1
@komalg1
Merge branch 'Azure-Samples:main' into main
ca5603e
@komalg1
Merge branch 'main' of https://github.com/komalg1/chat-with-your-data…
25dfd7d 
…-solution-accelerator
@komalg1
Merge branch 'Azure-Samples:main' into main
b4e0ed7
@komalg1
Merge branch 'Azure-Samples:main' into main
bf572b5
@komalg1
Merge branch 'Azure-Samples:main' into main
c4b451f
@komalg1
Merge branch 'Azure-Samples:main' into main
dabf403
@komalg1
Merge branch 'Azure-Samples:main' into main
79e4841
@komalg1
Merge branch 'Azure-Samples:main' into main
6d85cae
@komalg1
Merge branch 'Azure-Samples:main' into main
b44ff38
@komalg1
Merge branch 'Azure-Samples:main' into main
022be98
@komalg1
Delete files from storage
a0e1fd0
superhindupur
superhindupur reviewed May 14, 2024
View reviewed changes
code/backend/pages/03_Delete_Data.py
@@ -65,6 +66,9 @@
files_to_delete = search_handler.delete_files(
selected_files,
)
# Delete from Storage
blob_client = AzureBlobStorageClient()
blob_client.delete_files(selected_files)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that @liammoat is handling the blob delete event to delete the document from the search index under #893, do you think we should just do the blob delete from here, and let the function trigger handle the index delete?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes will close this PR for now and wait for @liammoat changes to go in

@superhindupur superhindupur mentioned this pull request May 14, 2024
Merged
3 tasks
@komalg1 komalg1 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdougal adamdougal adamdougal left review comments

@superhindupur superhindupur superhindupur left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@komalg1 @adamdougal @superhindupur