Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make backend orchestrator, parser, and plugins PEP8 #879

Merged
merged 9 commits into from May 14, 2024

Conversation

gaurarpit
Copy link
Collaborator

@gaurarpit gaurarpit commented May 13, 2024

Purpose

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Run the tests:
poetry run pytest -m "not azure and not functional"    
poetry run pytest -m "functional"  

What to Check

  • Verify that the content is available.

SCR-20240513-kvtl-2

@gaurarpit gaurarpit self-assigned this May 13, 2024
Copy link

github-actions bot commented May 13, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   orchestrator_helper.py13469%22–24, 27
code/backend/batch/utilities/helpers/config
   config_helper.py1230100% 
code/backend/batch/utilities/orchestrator
   __init__.py110100% 
   lang_chain_agent.py601968%21–24, 26, 61–62, 82–85, 102–103, 106–109, 116–117
   open_ai_functions.py543633%62, 64, 70–73, 75, 78, 85–89, 93–94, 96, 102–106, 110–112, 115, 118–119, 122, 127–129, 132–134, 137, 142
   orchestration_strategy.py50100% 
   orchestrator_base.py50884%33, 72–74, 81–83, 93
   semantic_kernel.py540100% 
   strategies.py12741%8–13, 15
code/backend/batch/utilities/parser
   output_parser_tool.py390100% 
   parser_base.py9277%9, 19
code/backend/batch/utilities/plugins
   chat_plugin.py150100% 
   post_answering_plugin.py80100% 
TOTAL229667570% 

Tests Skipped Failures Errors Time
178 0 💤 0 ❌ 0 🔥 11.672s ⏱️

@gaurarpit gaurarpit marked this pull request as ready for review May 13, 2024 11:06
superhindupur
superhindupur previously approved these changes May 14, 2024
Copy link
Collaborator

@superhindupur superhindupur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you'll need to update and fix conflicts though.

@gaurarpit gaurarpit enabled auto-merge May 14, 2024 08:50
@gaurarpit gaurarpit added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit e60816d May 14, 2024
9 checks passed
@gaurarpit gaurarpit deleted the arpit/refactor/pep8-orchestrator-parser-plugins branch May 14, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make parser and plugins PEP8 compliant Make Orchestrator PEP8 compliant
2 participants