Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data contextualization using sql graph to single_tech_samples #619

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add data contextualization using sql graph to single_tech_samples #619

wants to merge 5 commits into from

Conversation

cchenshu
Copy link
Contributor

@cchenshu cchenshu commented Feb 14, 2023 •
edited

Type of PR

  • Add a new sample to single_tech_samples/databricks

Purpose

  • This sample demonstrates how to contextualize data by looking up the relevant context from a graph model in Azure SQL Database.

@promisinganuj
Copy link
Contributor

@cchenshu Can we have DataContextualizationSolution.md merged to README.md? Also, I would suggest to make DataContextualizationSolution.md a lot lighter as we have already added most the information into playbook. For this sample, we can just keep the details which are really relevant.

promisinganuj
promisinganuj requested changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes.

single_tech_samples/databricks/sample5_data_contextualization_sql_graph/README.md Outdated Show resolved Hide resolved
single_tech_samples/databricks/sample5_data_contextualization_sql_graph/README.md Outdated Show resolved Hide resolved
single_tech_samples/databricks/sample5_data_contextualization_sql_graph/README.md Outdated Show resolved Hide resolved
...tech_samples/databricks/sample5_data_contextualization_sql_graph/src/notebooks/demo-setup.py Outdated Show resolved Hide resolved
single_tech_samples/databricks/sample5_data_contextualization_sql_graph/README.md
@@ -0,0 +1,33 @@
# Introduction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a dev container for running this sample?

promisinganuj
promisinganuj reviewed Mar 8, 2023
View reviewed changes
...le_tech_samples/databricks/sample5_data_contextualization_sql_graph/src/sql/create-graph.sql
@@ -0,0 +1,39 @@
DROP TABLE IF EXISTS Alarm;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a specific "database" for these tables?

@promisinganuj
Copy link
Contributor

@gary918 , @cchenshu , now that we have published the blog, we can go ahead with this sample.
I will review it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@promisinganuj promisinganuj promisinganuj requested changes

@gary918 gary918 Awaiting requested review from gary918

Requested changes must be addressed to merge this pull request.

Assignees

@cchenshu cchenshu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cchenshu @promisinganuj