Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev container config update #635

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

algattik
Copy link

@algattik algattik commented May 15, 2023

Type of PR

  • Documentation changes
  • Code changes

Purpose

Upgrade dev container configuration to current standards, and misc improvements.

  • Removed JAVA_HOME Docker env var, as the path is incorrect on non AMD64 arch (e.g. Mac M1), and variable is not needed by Pyspark
  • Aligned python versions with Databricks Runtime
  • Updated devcontainers.json format to current standard (previous format gave warnings in viscose)
  • Include .git folder in container to enable git integration
  • Also lint tests with flake8, not only runtime code
  • Updated README for new behavior of test extension
  • Updated obsolete collect_ignore pytest parameter
  • Misc improvements

Does this introduce a breaking change? If yes, details on what can break

No

Author pre-publish checklist

Validation steps

Run unit tests in dev container on VSCode

Issues Closed or Referenced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant