fix(parking-sensors): changed from root to non-root devcontainer #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StromFLIX
changed the title
cpeeyush
reviewed
Aug 10, 2023
|
|
||
| # Set user to non-root user to get rid of permission errors | ||
| USER $USERNAME |
There was a problem hiding this comment.
I know it is in draft, But just adding my thoughts here to keep track:
- We need to update docker-compose , devcontainer.json as well. And docker-compose should specify the user so that mounted workspace usages the same permission.
- I think it will be good if switch to $USERNAME before we copy the files otherwise still there will some files owner by root.
- We need to create virtual env in a location which is owned by $USERNAME otherwise in devcontainer we will not be able to add new dependencies without switching to root first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Purpose
In bug #646 we see a permission error on wsl when setting up the dev container with the root user
Author pre-publish checklist
Validation steps
Run the devcontainer in wsl like described in the issue #646
Issues Closed or Referenced