Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Anuj] Adding Fabric CI/CD sample #695

Merged
merged 77 commits into from
May 23, 2024
Merged

[Anuj] Adding Fabric CI/CD sample #695

merged 77 commits into from
May 23, 2024

Conversation

promisinganuj
Copy link
Contributor

@promisinganuj promisinganuj commented Apr 7, 2024

Type of PR

  • Documentation changes
  • Code changes

Purpose

  • Adding a new single-tech sample for Fabric CI/CD.
  • Updating some other pages to fix linting issues related to broken links.

Does this introduce a breaking change? If yes, details on what can break

  • No, it's a new sample.

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Test the sample based on the README.md.

Issues Closed or Referenced

devlace and others added 30 commits March 20, 2024 15:31
Co-authored-by: sreedhar-guda <sreedharab@gmail.com>
Co-authored-by: sreedhar-guda <sreedharab@gmail.com>
…e-pipelines

Adding CD release code and documentation
…strap

[ANUJ] Bootstrap fixed and documentation update
…strap

[Fabric CI/CD] Adding architecture diagram
[Fabric CI/CD] - Adding timeout to CD and final documentation changes
@promisinganuj promisinganuj added the single-tech: fabric Single-tech sample for Microsoft Fabric label Apr 7, 2024
@promisinganuj promisinganuj self-assigned this Apr 7, 2024
Copy link
Contributor

@sreedhar-guda sreedhar-guda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the bootstrap for new changes and it worked as expected.

Copy link
Contributor

@ydaponte ydaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but added some suggestion to the CD part that should be changed before the merge. Also, there are some clean-up included - we should make a small note on the PR goals as some of the files are not related with the current scope of the PR. Other than that it looks good to me! Thanks!

archive/e2e_samples/mdw_governance/README.md Show resolved Hide resolved
single_tech_samples/fabric/fabric_ci_cd/README.md Outdated Show resolved Hide resolved
single_tech_samples/fabric/fabric_ci_cd/README.md Outdated Show resolved Hide resolved
single_tech_samples/fabric/fabric_ci_cd/README.md Outdated Show resolved Hide resolved
single_tech_samples/fabric/fabric_ci_cd/README.md Outdated Show resolved Hide resolved
single_tech_samples/fabric/fabric_ci_cd/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ydaponte ydaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank YOU!

@promisinganuj promisinganuj merged commit 221732b into main May 23, 2024
3 of 4 checks passed
@promisinganuj promisinganuj deleted the feat/fabric_cicd branch May 23, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
single-tech: fabric Single-tech sample for Microsoft Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants