This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Add nodeSelector in all packs defining operating system #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds following `nodeSelector` with key `beta.kubernetes.io/os` to all language packs. With value being `linux` for packs that can work on linux OS nodes and value `windows` for pack(here csharp) that needs windows OS to run. Signed-off-by: Suraj Deshmukh <surajd.service@gmail.com>
|
|
|
ping @radu-matei |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds following
nodeSelectorwith keybeta.kubernetes.io/osto all language packs. With value beinglinuxfor packs that can work on linux OS nodes and value
windowsforpack(here csharp) that needs windows OS to run.
Fixes https://github.com/Azure/draft/issues/817