Support for multiple monitors #5
Conversation
- Manage the brightness individually for each connected external monitor. - Read the brightness from the target monitor if available; otherwise maintain a @[display_id: brightness] dictionary in the user defaults. - Display the Brightness system OSD on the target monitor. - Upgraded DDC to a more-recent version. - Removed useless CoreGraphicsPriv.h.
If the app is not trusted in the Accessibility preference panel when started, it now waits that the user trusts it before installing the key event monitor. Previously the app had to be relaunched after being authorized to grab the keys, which was not user-friendly at all, because that the app is invisible and had to be killed via the Activity Monitor!!
- Waiting for accessibility authorization is now done using the selector-based NSTimer API, making it work on macOS versions < 10.12. - Updated version information and copyright.
- Show the brightness level pane on the target display if the brightness level is not actually changed because already at the min or max level. - [Internal] Declare C functions and variable as static in AppDelegate.m to better express their expected scope.
- Rewritten management of the brightness level, so that possible brightness levels are evenly distributed in the monitor's possible range. - Added the support of quarter-step adjustments when the Option modifier key is pressed (similar to the system brightness management on the internal display when Shift+Option is pressed).
|
Sorry for the late reply on this PR. I appreciate the PR and will test it asap. |
|
@Bensge And what option should do? I’m just implementing this.. |
|
@KAMIKAZEUA the option should allow the user to chose one of the following behaviors:
|
|
@Bensge Okay, I will create it, but I don't know yet where I can use it in a code :) Next plan - add controls for color temperature, because I'm using these options always at the same time. But this option can be disabled in settings. Thats the plan. |
- Brightness adjustment now targets the main screen if the `shift` key modifier is not pressed, and all screens if `shift` is pressed in conjunction with F1 or F2. - Display the native brightness OSD on every adjusted screen. - Support brightness adjustment of the builtin screen with F1 / F2 for consistency with external screens.
Hi,
This pull request contains a number of improvements centered around the support of multiple external displays.
In summary (extract from the commits):