Add missing extra headers for other bedrock models #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
krrishdholakia
requested changes
May 11, 2024
| @@ -5921,15 +5921,15 @@ def get_supported_openai_params(model: str, custom_llm_provider: str): | |||
| elif model.startswith("anthropic"): | |||
| return litellm.AmazonAnthropicConfig().get_supported_openai_params() | |||
| elif model.startswith("ai21"): | |||
| return ["max_tokens", "temperature", "top_p", "stream"] | |||
| return ["max_tokens", "temperature", "top_p", "stream", "extra_headers"] | |||
There was a problem hiding this comment.
@themrzmaster 'extra_headers' isn't an openai param afaik.
LiteLLM should already be passing this straight through to bedrock, without needing this code block.
Please can you remove this
|
hey @themrzmaster is this still needed after the move to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this PR: #3299
it currently only works for anthropic. This PR make ir work for other bedrock models