Ignore 0 failures and 0s latency in daily slack reports #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
since it's not guaranteed to always be 5, it will be at most 5, but could be less than 5 (if some values are 0s now that we ignore 0s)
|
Is this ready for review? @taralika And can we have a simple unit test for this - litellm/litellm/tests/test_alerting.py Line 228 in aa2f6aa |
|
Thanks for adding the tests @taralika - if you can share a screenshot of it passing for you, this should be good to merge in |
Also fixed the issue that MagicMock does not create asynchronous mocks by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Ignore metrics values that are 0
cc: @msabramo
Relevant issues
Should fix #3598
Type
🐛 Bug Fix
Changes
Testing
Notes
Pre-Submission Checklist (optional but appreciated):
OS Tests (optional but appreciated):