Add ability to customize slack report frequency #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via `SLACK_DAILY_REPORT_FREQUENCY` env var Addresses one thing that @taralika mentioned in BerriAI#3597
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
can you add this to docs - https://docs.litellm.ai/docs/proxy/alerting#step-1-add-a-slack-webhook-url-to-env |
in `docs/my-website/docs/proxy/alerting.md`
ishaan-jaff
requested changes
May 14, 2024
| @@ -33,13 +34,11 @@ general_settings: | |||
| alerting: ["slack"] | |||
| alerting_threshold: 300 # sends alerts if requests hang for 5min+ and responses take 5min+ | |||
|
|
|||
| environment_variables: | |||
| SLACK_WEBHOOK_URL: "https://hooks.slack.com/services/<>/<>/<>" | |||
| SLACK_DAILY_REPORT_FREQUENCY: "86400" # 24 hours; Optional: defaults to 12 hours | |||
There was a problem hiding this comment.
please can you add more detail on what the daily reports are? A user might be unsure about what this param means / controls
There was a problem hiding this comment.
Sure! How about 4645451?
ishaan-jaff
approved these changes
May 14, 2024
| @@ -33,13 +34,11 @@ general_settings: | |||
| alerting: ["slack"] | |||
| alerting_threshold: 300 # sends alerts if requests hang for 5min+ and responses take 5min+ | |||
|
|
|||
| environment_variables: | |||
| SLACK_WEBHOOK_URL: "https://hooks.slack.com/services/<>/<>/<>" | |||
| SLACK_DAILY_REPORT_FREQUENCY: "86400" # 24 hours; Optional: defaults to 12 hours | |||
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via
SLACK_DAILY_REPORT_FREQUENCYenv varAddresses one thing that @taralika mentioned in #3597