Allowing -1 as a value for CONFIG_TFT_CS. #3309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: When the library get configured using the `idf.py menuconfig` tool(the lib used as an ESP-IDF component), the CONFIG_TFT_CS config used for selecting the pin used as the TFT_CS pin. However a check exists in the `TFT_config.h` that raises an error if the value of CONFIG_TFT_CS is -1, this check should be removed since -1 is needed as an value to allow manual control for the CS pin (manual control for the CS pins is needed for controlling more than one screen).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When the library get configured using the
idf.py menuconfigtool(the TFT_eSPI lib used as an ESP-IDF component), theCONFIG_TFT_CSconfig is used for setting theCSpin. However a check exists in theTFT_config.hfile that raises an error if the value ofCONFIG_TFT_CSis-1, this check should be removed since-1as a value is allowed by the library itself[1, 2] to allow disabling the automatic control of theCSpin which is needed in some cases like controlling more than one screen.