Add unit test and sample for UNSYNCEDLYRICS vorbis tag #1636
Conversation
|
Could you please merge this? Or is there something else I need to take care of? |
There was a problem hiding this comment.
Thanks for your contribution @Vorelli, in principal a good change.
Please update the PR title and description.
The PR title is used in the change-log, to summarize this improvement, as port of the next release, to the user. In the description (initial comment) you can be more specific. If possible link to UNSYNCEDLYRICS documentation or other reference material describing this tag.
Advice for future PR's, do not no use your master branch to create a PR. That prevents you from syncing changes from this master in your local clone.
There was a problem hiding this comment.
Please use a much smaller sample, truncate the audio content to a minimum.
yarn.lock
Outdated
There was a problem hiding this comment.
This change should not be part of this PR.
| flacFilePath, | ||
| "Sister City - Swan Dive - 01 Attenborough Blues.flac" | ||
| ); | ||
| const { format, common, native } = await mm.parseFile(filePath); |
| assert.strictEqual(format.container, "FLAC", "format.container"); | ||
| assert.strictEqual(format.codec, "FLAC", "format.codec"); | ||
|
|
||
| assert.strictEqual(common.lyrics instanceof Array && common.lyrics[0] && common.lyrics[0].length > 0, true); |
There was a problem hiding this comment.
Be verbose and explicit unit test, provide clear message where and what is wrong in case of failing unit test.
| assert.strictEqual(common.lyrics instanceof Array && common.lyrics[0] && common.lyrics[0].length > 0, true); | |
| assert.isArray(common.lyrics, 'common.lyrics'); | |
| assert.isNotEmpty(common.lyrics, 'common.lyrics'); |
| "A primate blessed with common sense\r\n" + | ||
| "With empathy and with arrogance\r\n" + | ||
| "I am swinging from the trees\r\n" + | ||
| "I am crawling out of the sea" |
There was a problem hiding this comment.
Include the metadata field name you are checking:
| "I am crawling out of the sea" | |
| "I am crawling out of the sea", 'common.lyrics'); |
Vorelli
force-pushed
the
master
branch
2 times, most recently
from
749649b
to
1555826
Compare
No description provided.