New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature field and component support #13418
Conversation
…ield-and-component
…ield-and-component
…ield-and-component
…ield-and-component
…ield-and-component
…ield-and-component
…ield-and-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Dean! Nothing major but just a few suggestions 👌
packages/builder/src/components/backend/DataTable/TableDataTable.svelte
Outdated
Show resolved
Hide resolved
packages/frontend-core/src/components/grid/cells/SignatureCell.svelte
Outdated
Show resolved
Hide resolved
…ield-and-component
…ield-and-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion to update the grid cell to use the latest components, but otherwise LGTM! This is so smooth to write on, I love it 😂
…ield-and-component
Bit of a random one, but if you just click (don't drag) you get lines shooting in from the top left... Not a massive issue lol unless there's an easy fix. Edit: as @mike12345567 pointed out it probably actually does need fixed if possible, because it would be impossible to dot an "i" otherwise (you'd get a weird line in the top left). Edit 2: I can see you dotted i's successfully in your demo video, so I'm puzzled. |
@aptkingston there appears to be a recent issue around this on the framework itself jakubfiala/atrament#99 Switching to the version from 3 weeks ago might fix the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still being broken for me using firefox on a mac. Happy to debug today to see if we can reproduce it
Had a call with @adrinr this morning to run through this and the error he's seeing is definitely happening. It seems that it only occurs when the component is loaded on a native/laptop monitor 🙃. The canvas get's resized to 800x400 irrespective of the configuration. This was reproducible in Firefox and Chrome. Reviewing the issue now. This was due to |
…the canvas for devices with higher DPI screens only affecting macs
…ield-and-component
… until the canvas is actually changed. Upgraded atrament to the latest
@aptkingston @mike12345567 added a fix for the issue around clicking on the canvas. The issue manifests itself if you click in exactly same area without moving. I added a check for where the last draw ended and where the pointer is on click. If they match exactly, the draw behaviour will be canned and the odd lines wont appear. |
Ah I see - I think the common manifestation of this is then if you have never clicked yet, it treats it as if you've clicked in the same area since your reference point is null. |
…gnature-field-and-component
…dibase/budibase into feature/signature-field-and-component
Requested refactoring has been complete
Description
Enhance your app with direct signature capture in Budibase forms!
Signature
data type.SignatureField
component type..png
files and can be embedded in your applications.mouse
capture and alsotouch
entry for mobile users.Addresses
Bug
- Single attachment validation behaviour was missing. It has now been added and supportsRequired
andMax upload size
optionsBug
- added support for single attachment type in the edit row modal.Screenshots
View and edit signature in the data section
Capture signatures in your app forms!
Launchcontrol
Signature field support added to internal datasources and forms.
Feature branch env
Feature Branch Link