Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Single user column #13604

Merged
merged 105 commits into from May 13, 2024
Merged

[Feat] Single user column #13604

merged 105 commits into from May 13, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented May 3, 2024

Description

Feature branch for the new single user column. This only includes the following reviewed PRs:

Addresses

QA scenarios

Tested DBs:

  • Internal couch
  • PG
  • MSSQL
  • MYSQL
  • Google sheets

Tested scenarios

  • Existing single user column can be fetched and displayed in grid, form and as binding
  • Existing multiple user column can be fetched and displayed in grid, form and as binding
  • Existing single user column data can be edited
  • Existing multiple user column data can be edited
  • Data section shows the correct grid headers for existing columns
  • Data section shows the correct dropdown info on edit column
  • New single user column can be created, populated and edited. Bindings still work
  • New single user column can be created, populated and edited. Bindings still work
  • Existing user list can still be can be created, populated and edited
  • Import/export works
  • User relationship -> user column migration (only for internal db)
  • All column types (existing and news) can be exported and imported
  • Filter grid by value
  • Filter grid by bindings
  • Dynamic filter

Launchcontrol

Adding a new column type for single user references

@adrinr adrinr requested a review from samwho May 9, 2024 18:00
Copy link
Collaborator

@samwho samwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is an amalgamation of the linked PRs, I'm giving it an approval so we can get it in next week. 🙂

Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can't wait to use this, massive improvement to the binding experience!

@adrinr adrinr enabled auto-merge May 13, 2024 11:35
@adrinr adrinr merged commit fc4f271 into master May 13, 2024
10 checks passed
@adrinr adrinr deleted the feat/budi-8123-single-user branch May 13, 2024 11:42
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-branch Release this PR code into a feature branch firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants