Fix for positioning of selected builder navigation tab on page load #13636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aptkingston
approved these changes
May 13, 2024
packages/builder/src/pages/builder/app/[application]/_layout.svelte
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The underline on the builder tab navigation would periodically get stuck in the wrong position when the page loaded. This was caused by the header rendering before the fonts had finished loading.
Addresses
fontsprop is updated, the tabs can use it to trigger a re-render and position the underline correctly.Screenshots
The issue
Launchcontrol
Ensure the builder tabs redraw as the fonts load, ensuring the current tab is correctly underlined.