Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SDKs: data repeat memory issues #3262

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

samijaber
Copy link
Contributor

@samijaber samijaber commented May 2, 2024

Description

  • works but breaks visual editor experience (endless re-renderings)

Copy link

changeset-bot bot commented May 2, 2024

⚠️ No Changeset found

Latest commit: dff5c02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-app-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 1:51pm
nextjs-pages-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 1:51pm
remix-gen2-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 1:51pm
svelte-vite-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 1:51pm

Copy link

gitguardian bot commented May 2, 2024

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9508867 Triggered Generic High Entropy Secret e5101b3 examples/react-v2/src/sdk-src/blocks/video/component-info.ts View secret
314150 Triggered Generic High Entropy Secret a1903c3 packages/sdks/src/functions/get-content/snapshots/generate-content-url.test.ts.snap View secret
314150 Triggered Generic High Entropy Secret a1903c3 packages/sdks/src/functions/get-content/snapshots/generate-content-url.test.ts.snap View secret
314150 Triggered Generic High Entropy Secret e5101b3 examples/react-v2/src/sdk-src/blocks/video/component-info.ts View secret
314150 Triggered Generic High Entropy Secret a1903c3 packages/sdks/src/functions/get-content/snapshots/generate-content-url.test.ts.snap View secret
314150 Triggered Generic High Entropy Secret a1903c3 packages/sdks/src/functions/get-content/snapshots/generate-content-url.test.ts.snap View secret
314150 Triggered Generic High Entropy Secret a1903c3 packages/sdks/src/functions/get-content/snapshots/generate-content-url.test.ts.snap View secret
375826 Triggered Generic High Entropy Secret e5101b3 examples/react-v2/src/sdk-src/blocks/img/component-info.ts View secret
375826 Triggered Generic High Entropy Secret e5101b3 examples/react-v2/src/sdk-src/blocks/image/component-info.ts View secret
375826 Triggered Generic High Entropy Secret a1903c3 packages/amp/src/components/Image.tsx View secret
375826 Triggered Generic High Entropy Secret a1903c3 packages/email/src/components/Image.tsx View secret
375828 Triggered Generic High Entropy Secret e5101b3 examples/react-v2/src/sdk-src/blocks/video/component-info.ts View secret
375827 Triggered Generic High Entropy Secret e5101b3 examples/react-v2/src/sdk-src/blocks/text/component-info.ts View secret
375825 Triggered Generic High Entropy Secret e5101b3 examples/react-v2/src/sdk-src/blocks/embed/component-info.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant