Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHIA-427] Port chia wallet take/cancel_offer to @tx_out_cmd #18038

Merged
merged 1 commit into from
May 20, 2024
Merged

[CHIA-427] Port chia wallet take/cancel_offer to @tx_out_cmd #18038

merged 1 commit into from
May 20, 2024

Conversation

Quexington
Copy link
Contributor

This brings another set of commands to the @tx_out_cmd decorator which gives it the capability to optionally push a transaction and export the transactions to a local file.

@Quexington Quexington changed the title Port chia wallet take/cancel_offer to @tx_out_cmd [CHIA-427] Port chia wallet take/cancel_offer to @tx_out_cmd May 17, 2024
@Quexington Quexington added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label May 17, 2024
@Quexington Quexington marked this pull request as ready for review May 17, 2024 16:14
@Quexington Quexington requested a review from a team as a code owner May 17, 2024 16:14
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/wallet_funcs.py 83.3% lines 715, 794
Total Missing Coverage
19 lines 2 lines 89%

wjblanke
wjblanke approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Quexington Quexington merged commit 0afa088 into long_lived/vault May 20, 2024
362 of 364 checks passed
@Quexington Quexington deleted the quex.port_offer_cmds_to_tx_out_cmd branch May 20, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Quexington @AmineKhaldi @wjblanke