Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-365] Return exception and error from get_kv_diff when either of the hashes has no data #18039

Merged
merged 2 commits into from
May 22, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented May 17, 2024

Fix issue where get_kv_diff returns an empty diff even though one of the provided hashes has no data. Instead this will return an error code about unable to perform the diff because there wasn't any data to diff.

@emlowe emlowe requested a review from altendky May 17, 2024 20:21
@emlowe emlowe added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label May 17, 2024
Copy link

Pull Request Test Coverage Report for Build 9134173387

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.04%) to 90.849%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 72.57%
chia/farmer/farmer.py 1 72.23%
chia/wallet/wallet_node.py 1 88.72%
chia/data_layer/data_layer.py 2 85.32%
chia/daemon/client.py 2 73.33%
Totals Coverage Status
Change from base Build 9129839013: 0.04%
Covered Lines: 99217
Relevant Lines: 109152

💛 - Coveralls

@emlowe emlowe marked this pull request as ready for review May 20, 2024 16:55
@emlowe emlowe requested a review from a team as a code owner May 20, 2024 16:55
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cmmarslender cmmarslender merged commit b76a4f4 into main May 22, 2024
361 checks passed
@cmmarslender cmmarslender deleted the EL.CHIA-365.get_kv_diff branch May 22, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants