Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Forge of Wonder Globally Unique #73578

Merged
merged 5 commits into from May 19, 2024

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

The Forge was intended to be globally unique but the code to make it so didn't exist when it was first made. Now it does.

Describe the solution

Adds Globally unique flag.

Describe alternatives you've considered

Making it more rare than 1/16

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod labels May 8, 2024
@TheAthenaCabin0
Copy link
Contributor

iirc there are a few lines of dialogue from the various traders there that would have to be changed in addition to this flag - they indicate that there are many copies of the forge all over the world. Would that be fitting for a different pr?

@github-actions github-actions bot requested a review from KorGgenT May 8, 2024 05:56
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 8, 2024
@SariusSkelrets
Copy link
Contributor

The diviner can give you directions to another forge, while saying that Valzaim intended having that many forges as part of a "plan" he have

It will definetly need to be changed should the location becomes globally unique

@github-actions github-actions bot added Missions Quests and missions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 8, 2024
@b3brodie
Copy link
Contributor

b3brodie commented May 8, 2024

As an addition to this, since the forge will be unique I think it makes sense to give the npcs defined personalities. Right now they're rolled randomly, which is very apparent on the traders and can lead to some dramatically different pricing.

@TheAthenaCabin0
Copy link
Contributor

It feels like adding distinct personalities and fleshing out the forge a bit more ties in with #73434. Maybe a forge overhaul is due à la the various faction overhauls we are seeing (exodii, hub, isherwoods, etc). Later this week I'll try to draft a pr on that matter, resolving some of the QoL features at least.

@Maleclypse
Copy link
Member Author

It feels like adding distinct personalities and fleshing out the forge a bit more ties in with #73434. Maybe a forge overhaul is due à la the various faction overhauls we are seeing (exodii, hub, isherwoods, etc). Later this week I'll try to draft a pr on that matter, resolving some of the QoL features at least.

Definitely support giving the various traders more definite traits and dialogue. While testing the above issue I discovered that forge dwarves can just wander into the lava. Added the higher level of danger avoid to fix that.

@Procyonae
Copy link
Contributor

Unless I'm missing something the talk topic TALK_FORGE_LORD_DIVINER_OTHER_FORGE where the mission is assigned also needs changing

@Maleclypse
Copy link
Member Author

Unless I'm missing something the talk topic TALK_FORGE_LORD_DIVINER_OTHER_FORGE where the mission is assigned also needs changing

What do you think about that change I've just pushed?

@github-actions github-actions bot removed BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 12, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 15, 2024
@dseguin dseguin merged commit 140db31 into CleverRaven:master May 19, 2024
19 of 24 checks passed
@Maleclypse Maleclypse deleted the Make-the-Forge-Globally-Unique branch May 20, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants