Support selecting items based on input. #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i merge the pull request on my fork ,but i found this can not response to up,down key event。and enter key not select clip to paste and dismiss the menu |
|
Hmmm, they are working for me, I've been running this branch for several months without issue. |
|
I have the same problem as @runforprogram, it will be good to have this ability in Clipy. |
|
Hmm, I don't really know how to debug this as it works for me fine. I'm also on 10.13.6... |
|
@facetoe could you please rebase your branch to resolve conflicts? |
|
Yep I'll try to fix it up this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I am not a OSX dev. This may be a horrible hack, but it works for me...
This PR adds support for selecting an item based on entered input. I slightly modified the
NSViewsubclass from https://github.com/mikekazakov/MGKMenuWithFilter/blob/master/README.md and plonked it into place.