Fixes "Menu Bar Items Not Updating (#1684)"

[danielzsh]

Description

The issue is described in detail in #1684.

I tried to resolve a related issue, #1696, but it was harder than I anticipated since the state of the Utility Area is stored separate to the other panes for some reason. Any ideas to resolve this slight issue would be welcome :)

EDIT: I think I fixed it!

Related Issues

• Closes 🐞 Menu Bar Items Not Updating #1684
• Closes 🐞 Hide Utility Area Command tied to Inspector instead of Utility Area #1696

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

Screen.Recording.2024-05-01.at.9.08.19.AM.mov

[thecoolwinter]

I fix lint errors and I can review 👍

[danielzsh]

By the way, the SwiftLint error feels a bit overly constraining, especially considering it limits the class body to 250 lines and my code currently has 251; is there a way to perhaps silence the warning, or is that not recommended?

[matthijseikelenboom]

Yeah I don't understand why it gives an error now on that file. The length of the class is way longer than 251 lines...

[danielzsh]

@thecoolwinter bump?

[thecoolwinter]

Yeah swiftlint errors can be annoying, especially when it's one line over the limit. But in this case we can just move some code to an extension. I believe all the toolbar code can be moved to a new file without modification (lines 141-238ish). Just a new file in the same dir named CodeEditWindowController+Toolbar.swift.

[danielzsh]

@thecoolwinter does this look good?

[thecoolwinter]

Looks good, thanks for your patience!

[austincondiff]

@allcontributors add @danielzsh for bug

[allcontributors]

@austincondiff

I've put up a pull request to add @danielzsh! 🎉