New tabs after current focus Bug Fix for issue #1704 #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed tab append to tab insert at index after selected tab
Fixed issue where tab deleted tab next to it.
Fixed issue where closing a file on the side window caused an error.
FastestMolasses
previously approved these changes
May 16, 2024
thecoolwinter
previously approved these changes
May 16, 2024
|
Resolve conflicts and this can be merged |
Shivam-Parekh
dismissed stale reviews from thecoolwinter and FastestMolasses
via
f25e6c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix of a bug found in #1715.
The bug occurred where opening up a side window of a file and closing that side windowed file caused an exception. This occurred due to returning the function to early with in the guard. The fix switched the guard to an if else statement to allow the rest of the function to run on that occurrence.
Issue:
Related Issues
Checklist
Screenshots
Before:
https://github.com/CodeEditApp/CodeEdit/assets/27977043/c4a9abe9-09cb-45ee-915d-d6c3963f08d0
Fix:
https://github.com/CodeEditApp/CodeEdit/assets/27977043/3fbe7b5e-272a-408d-8804-ffbed2d98705