Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View text files that are not UTF-8 encoded #1727

Conversation

plbstl
Copy link
Contributor

@plbstl plbstl commented May 20, 2024

Description

This PR allows CodeEdit to show file contents in a different encoding from utf8.

The files in the related issues show up. I don't know how accurately, but it does a good job.

NOTE: Files are still saved using UTF8 encoding.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

BEFORE:

cannot.view.text.files.that.are.not.UTF8.encoded.mov

AFTER:

view.text.files.that.are.not.UTF8.encoded.mov

Copy link
Member

@activcoding activcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austincondiff austincondiff self-requested a review May 21, 2024 12:37
@austincondiff austincondiff merged commit d51c9d2 into CodeEditApp:main May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants