Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix: #32) Fix Deleting Selected Range #33

Merged
merged 1 commit into from
May 21, 2024

Conversation

thecoolwinter
Copy link
Contributor

@thecoolwinter thecoolwinter commented May 18, 2024

Description

Fixes deleting a selected range, before would extend the selection range when deleting no matter what. This fixes it to only extend the range if it's a cursor rather than a selected range.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-05-18.at.9.58.16.AM.mov

Copy link
Contributor

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@austincondiff austincondiff merged commit 80911be into CodeEditApp:main May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Selecting text and then pressing delete key deletes selection and one character preceding selection
2 participants