Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nullish coalescing to determine path #661

Open
wants to merge 1 commit into
base: mainline
Choose a base branch
from

Conversation

sanderkoenders
Copy link

Issue #, if available:
We are currently struggling with a situation where /test proxies to a lambda. This causes event.pathParameters.proxy to be undefined. The request is then translated to /test rather than /.

Description of changes:
To solve this we want to overwrite event.pathParameters.proxy with an empty string but the absence of nullish coalescing causes this to still use the event.path rather than event.pathParameters.proxy

Checklist

  • Tests have been added and are passing
  • Documentation has been updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

We are currently struggling with a situation where `/test` proxies to a lambda. This causes `event.pathParameters.proxy` to be `undefined`. The request is then translated to `/test` rather than `/`.

To solve this we want to overwrite `event.pathParameters.proxy` with an empty string but the absence of nullish coalescing causes this to still use the `event.path` rather than `event.pathParameters.proxy`
@brettstack
Copy link
Collaborator

Hey @sanderkoenders could you share the test case for when ?? would result in a different output than || ? In this scenario, both yield the same result:

let event = { path: '/test', pathParameters: { proxy: undefined } }
let path
path = (event.pathParameters && event.pathParameters.proxy && `/${event.pathParameters.proxy}`) || event.path
console.log(path)
path = (event.pathParameters && event.pathParameters.proxy && `/${event.pathParameters.proxy}`) ?? event.path
console.log(path)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants