Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use YouTube source plugin over the deprecated built-in source #6373

Open
wants to merge 3 commits into
base: V3/develop
Choose a base branch
from

Conversation

Jackenmen
Copy link
Member

Description of the changes

This PR switches our auto-generated Lavalink application.yml file to use the YouTube source plugin over the deprecated built-in source. The proposed implementation does not define this plugin in the Config defaults under the yaml key and instead dynamically generates it in the ServerManager.process_settings() method. The upsides here are:

  • we can keep the existing (user-configurable) config value for the YouTube source and use that to determine if the plugin should be enabled
  • we won't accidentally enable both the built-in source and the plugin
  • the YT plugin version constant can be set right under the LL version, making it easier for us to update

The downside is that the defaults are no longer placed in a single spot. It is not ideal but there's a need for some redesign to support plugins anyway so I figure this is likely a better solution, at least for now.

Have the changes in this PR been tested?

Yes

@Jackenmen Jackenmen added the Type: Enhancement Something meant to enhance existing Red features. label May 5, 2024
@Jackenmen Jackenmen added this to the 3.5.10 milestone May 5, 2024
@github-actions github-actions bot added Category: Cogs - Audio This is related to the Audio cog. labels May 5, 2024
@aikaterna aikaterna self-assigned this May 5, 2024
@aikaterna
Copy link
Member

Do you think it would be worth having an info level log line on what plugins it's downloading, similar to other log lines exposed on audio/Lavalink.jar startup? Thinking of any potential support info needed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants