jsdailog:css: increase width to fit content in manage changes dialog #9067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @lpranam but with this commit specifically when using max-content which padding and surrounding context, granted you used also max-width to limit the side effects of that. Nevertheless the content is not wrapping (until it reaches the max-width). This in turn seems to make every jsdialog quite wide.
|
lpranam
force-pushed
the
js_dialog_width
branch
2 times, most recently
from
bc2aceb
to
f5442e3
Compare
lpranam
changed the title
|
Now it should only affect manage changes dialog :) @pedropintosilva |
pedropintosilva
requested changes
May 23, 2024
increased jsdialog width to fit content when necessary. removed margin from icon to make it look even spaced in listview (i.e: manage changes, zotero add citation) Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I225b5b5d42d573cb4afcdb428e2eb3b81aa99073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increased jsdialog width to fit content when necessary. max width is set to 1000px because some other dialog(i.e: Zotero) already uses tree widget width 800px which makes the entire dialog approx 990px.
removed margin from icon to make it look even spaced in listview (i.e: manage changes, zotero add citation)
Change-Id: I225b5b5d42d573cb4afcdb428e2eb3b81aa99073
Checklist
make checkmake runand manually verified that everything looks okay