Private/gokay/cell cursors #9104
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokaysatir
force-pushed
the
private/gokay/cell-cursors
branch
from
896a07b
to
ef20636
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gokaysatir
force-pushed
the
private/gokay/cell-cursors
branch
3 times, most recently
from
84ade6a
to
28122c0
Compare
gokaysatir
force-pushed
the
private/gokay/cell-cursors
branch
from
28122c0
to
3ee1091
Compare
| } | ||
|
|
||
| adjustSVGProperties() { | ||
| const scale = app.getScale(); |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
gokaysatir
force-pushed
the
private/gokay/cell-cursors
branch
3 times, most recently
from
119e9e7
to
2e58d7b
Compare
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: Icc14501bbf78556ad4e5bfb7fb3d6e8ec37191d8
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: Idea4181c5a405c461e4f3a60b0f21725ff06d1f9
gokaysatir
force-pushed
the
private/gokay/cell-cursors
branch
from
2e58d7b
to
c24486c
Compare
|
|
||
| return shapeRecProps; | ||
|
|
||
| dragDistance[0] *= app.pixelsToTwips; |
Check warning
Code scanning / CodeQL
Unreachable statement Warning
| @@ -51,6 +51,10 @@ | |||
| return app.file.readOnly; | |||
| }; | |||
|
|
|||
| app.getScale = function() { | |||
| return (app.tile.size.pixels[0] / app.tile.size.twips[0]) * 15; | |||
| } | |||
Check notice
Code scanning / CodeQL
Semicolon insertion Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay