Update IsChildOf graph walk in LayersGraph.cs #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the recursion here was intended to use the visited set of nodes as part of its traversal. In a quick test, I saw a Lottie json file load time go from 2 minutes down to 15 seconds.
It would be helpful to have some text art to show what this looks like. It's a little trouble to visualize. It's making it difficult to understand if there's better optimizations so that we don't need to call IsChildOf() at all. Refers to: source/LottieData/Optimization/LayersGraph.cs:15 in d0c6ca8. [](commit_id = d0c6ca8, deletion_comment = False) |
aborziak-ms
reviewed
May 16, 2024
…ptimize option set on the LottieVisualSource
aborziak-ms
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the recursive graph walk in LayersGraph.cs was intended to use the visited set of nodes as part of its traversal. In a quick test, I saw a Lottie json file load time go from 2 minutes down to 15 seconds.
Discovered by running the Visual Studio profiler over the Lottie Viewer