-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docker container contain all environments for all examples #75
Labels
good first issue
Good for newcomers
Comments
skrawcz
changed the title
Make docker container build all environments
Make docker container contain all environments for all examples
Feb 26, 2023
Noted. Let me take it up @skrawcz |
Hey, @skrawcz feeling better this week. Working on it. |
let me know when you want to sync. |
7 tasks
@CharityKithaka let me know if you're still working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The docker container created for the examples does not enable one to run all the examples. The script to build environments that is used in the build process, excludes building environments for examples that have multiple requirements files, e.g.
requirements-ray.txt
is required to runrun_ray.py
in the data_quality example. This means that people can only run one variant in these examples.Describe the solution you'd like
The build script should prepare all the environments in an example.
E.g.
requirements.txt
would map tohamilton-env
requirements-ray.txt
would map tohamilton-env-ray
requirements-dask.txt
would map tohamilton-env-dask
Describe alternatives you've considered
No doing this. Leaving things as is.
Additional context
Script in question:
https://github.com/DAGWorks-Inc/hamilton/blob/main/examples/make_python_virtualenv.sh
It is used here:
https://github.com/DAGWorks-Inc/hamilton/blob/main/examples/Dockerfile
The text was updated successfully, but these errors were encountered: