Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker container contain all environments for all examples #75

Open
skrawcz opened this issue Feb 26, 2023 · 5 comments · May be fixed by #166
Open

Make docker container contain all environments for all examples #75

skrawcz opened this issue Feb 26, 2023 · 5 comments · May be fixed by #166
Labels
good first issue Good for newcomers

Comments

@skrawcz
Copy link
Collaborator

skrawcz commented Feb 26, 2023

Is your feature request related to a problem? Please describe.
The docker container created for the examples does not enable one to run all the examples. The script to build environments that is used in the build process, excludes building environments for examples that have multiple requirements files, e.g.requirements-ray.txt is required to run run_ray.py in the data_quality example. This means that people can only run one variant in these examples.

Describe the solution you'd like
The build script should prepare all the environments in an example.
E.g.

  • requirements.txt would map to hamilton-env
  • requirements-ray.txt would map to hamilton-env-ray
  • requirements-dask.txt would map to hamilton-env-dask

Describe alternatives you've considered
No doing this. Leaving things as is.

Additional context
Script in question:
https://github.com/DAGWorks-Inc/hamilton/blob/main/examples/make_python_virtualenv.sh

It is used here:
https://github.com/DAGWorks-Inc/hamilton/blob/main/examples/Dockerfile

@skrawcz skrawcz added the good first issue Good for newcomers label Feb 26, 2023
@skrawcz
Copy link
Collaborator Author

skrawcz commented Feb 26, 2023

cc @CharityKithaka

@skrawcz skrawcz changed the title Make docker container build all environments Make docker container contain all environments for all examples Feb 26, 2023
@CharityKithaka
Copy link
Contributor

Noted. Let me take it up @skrawcz

@CharityKithaka
Copy link
Contributor

Hey, @skrawcz feeling better this week. Working on it.

@skrawcz
Copy link
Collaborator Author

skrawcz commented Mar 14, 2023

Hey, @skrawcz feeling better this week. Working on it.

let me know when you want to sync.

@skrawcz
Copy link
Collaborator Author

skrawcz commented Oct 24, 2023

@CharityKithaka let me know if you're still working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants