Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-75: Update build script to enable docker container contain all environments for all examples. #166

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CharityKithaka
Copy link
Contributor

@CharityKithaka CharityKithaka commented May 9, 2023

[Closes #75 : Modify the build script to facilitate the building of all environments based on the extensions on the requirements files on all modules.]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@CharityKithaka
Copy link
Contributor Author

CharityKithaka commented May 9, 2023

Hey, @skrawcz kindly find the above for your review.

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think I might have not explained the desired end state correctly. The ideal end state is that, for each example directory, there's a virtual environment corresponding to each requirements*.txt file.

From what I can tell, this does install all requirements*.txt files, however it installs all of them into the same virtual environment for an example.

Here's some pseudo code that is close to your code now, but adjust things slightly.

find all folders with requirements files
For each folder
   for each requirements file 
       determine whether file has suffix or not (e.g. ray, dask, or none)
       remove & create new environment with suffix
       activate the environment
       install that requirements file
       deactivate environment

Shouldn't be much to change what you have to reflect the above. Let me know if you have questions or need clarification.

@CharityKithaka
Copy link
Contributor Author

CharityKithaka commented Mar 26, 2024

Hey, @skrawcz wanted to confirm if this issue was closed or if its something that's still pending.🙂

Charity.

@skrawcz
Copy link
Collaborator

skrawcz commented Mar 26, 2024

Hey, @skrawcz wanted to confirm if this issue was closed or if its something that's still pending.🙂

Charity.

@CharityKithaka no this is still open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make docker container contain all environments for all examples
2 participants