Misc todos #183
Open
Misc todos #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a data validator specified the types it was allowed to process by a single function that accepted a type and outputted a boolean. Now it specifies those types by returning a list of types. This is consistent with how we do the same mechanism in data adapters.
Previously we had hardcoded rules that could occasionally clash. This anonymizes it every time. While this isn't the prettiest way to do it, its better than implementing state. Next up, we'll be building out tooling to mark these with tags as related to a cluster of nodes, and use that to group the DAG.
We had the order switched of a subclass call. This caused it to break in certain cases. We switched it back and added tests.
skrawcz
commented
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elijahbenizzy this needs more testing. See #182 .