WIP: Adapter to aid in debugging issues #762
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrawcz
force-pushed
the
feat_error_debug
branch
3 times, most recently
from
8362e90
to
ebad47e
Compare
skrawcz
commented
Mar 16, 2024
|
|
||
|
|
||
| class NotebookErrorDebugger(lifecycle.NodeExecutionHook): | ||
|
|
There was a problem hiding this comment.
TODO: add path/directory to save these to.
skrawcz
commented
Mar 16, 2024
| @@ -265,6 +277,7 @@ def post_node_execute( | |||
| task_id=task_id, | |||
| success=success, | |||
| run_id=run_id, | |||
| originating_function=node_.originating_functions[0], | |||
There was a problem hiding this comment.
TODO: change name.
TODO: Do we want to pass in all originating functions?
skrawcz
force-pushed
the
feat_error_debug
branch
from
ebad47e
to
4858121
Compare
Proof of concept. TODOs: - python dependency logging - creating a notebook version of this - tests - extensions would be to serialize things more effectively
Proof of concept. TODOs: - python dependency logging - creating a notebook version of this - tests - extensions would be to serialize things more effectively
skrawcz
force-pushed
the
feat_error_debug
branch
from
10d6daa
to
560550a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - showing how to capture data to enable someone to debug a function easily.
Changes
How I tested this
Notes
Checklist