Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typed tags #98

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Typed tags #98

wants to merge 2 commits into from

Conversation

elijahbenizzy
Copy link
Collaborator

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy
Prototype for typed_tag. Solve
8c48744 
stitchfix/hamilton#276

This is a little rough -- we need more testing. But it should work.
Followed the spec at it was fairly clean -- using typed dicts, and
validating on decoration. Also restricting to only primitives -- we can
change it later but I want to keep things a lot simpler for now.
@elijahbenizzy
Utilizes typing_extensions for backwards compatibility with TypedDict…
887dca5 
… import
@elijahbenizzy elijahbenizzy mentioned this pull request Mar 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@elijahbenizzy