Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next_observations and dones to RolloutBuffer #1267

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

taufeeque9
Copy link

@taufeeque9 taufeeque9 commented Jan 9, 2023

Description

This PR adds the next_observations and dones fields to the RolloutBuffer and the DictRolloutBuffer classes. The OnPolicyAlgorithm class is also changed to store both these fields. Closes #1273.

Motivation and Context

This change is required in imitation for the AIRL algorithm since it uses the next_observations field from the Buffer class to compute the reward.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@taufeeque9 taufeeque9 marked this pull request as draft January 9, 2023 13:27
@araffin
Copy link
Member

araffin commented Jan 10, 2023

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Store next observations and dones in RolloutBuffer
2 participants